ctubbsii commented on pull request #2318: URL: https://github.com/apache/accumulo/pull/2318#issuecomment-963513533
> I was able to test this with the page I am working on in the Monitor and I think it is good to go. The only thing I noticed that by having the Monitor make calls to the Compaction Coordinator, it introduces a Thrift dependency to the Monitor: > > [INFO] --- maven-dependency-plugin:3.1.2:analyze-only (analyze) @ accumulo-monitor --- > [WARNING] Used undeclared dependencies found: > [WARNING] org.apache.thrift:libthrift:jar:0.15.0:compile > I am OK with this. I was actually surprised there wasn't one already. I guess all the calls that go through the Manager don't require a direct dependency. I can't reproduce that, so I'm assuming you're describing changes not included in this PR. In general, it's best to keep our Thrift types from leaking too far from the RPC layer. The monitor shouldn't interact with Thrift at all. It should interact with other service APIs, and those service APIs should not leak Thrift types, if at all possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
