ctubbsii commented on pull request #2318: URL: https://github.com/apache/accumulo/pull/2318#issuecomment-964547107
> > I can't reproduce that, so I'm assuming you're describing changes not included in this PR. > > Yes. I am using `CompactionCoordinatorService.Client` to call the method `getRunningCompactions`. It returns multiple thrift types, TExternalCompactionList and TExternalCompaction. It's hard to troubleshoot without seeing your code. > > The monitor shouldn't interact with Thrift at all. It should interact with other service APIs, and those service APIs should not leak Thrift types, if at all possible. > > I don't understand what you mean. I am also not sure how the Monitor doesn't already have this dependency. The Monitor currently uses thrift types like `ManagerMonitorInfo` and `ManagerClientService` a great deal. I guess there are two kinds of "Thrift types". There's our autogenerated code, like those you mention (I still think they shouldn't leak into the monitor, but I guess they're not causing a problem right now) that are from our accumulo-core jar. And then there's types from the Thrift jar. maven-dependency-plugin is checking for compile-time dependencies, not runtime dependencies. So, it shouldn't complain unless the monitor references a type `org.apache.thrift.*`. For the examples you gave, we're never actually referencing any `org.apache.thrift.*` classes in the monitor, even if those classes themselves reference them (creating a runtime dependency). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
