milleruntime commented on a change in pull request #2342:
URL: https://github.com/apache/accumulo/pull/2342#discussion_r745042747
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
##########
@@ -811,7 +812,7 @@ DataFileValue minorCompact(InMemoryMap memTable, TabletFile
tmpDatafile, TabletF
var storedFile =
getDatafileManager().bringMinorCompactionOnline(tmpDatafile, newDatafile,
new DataFileValue(stats.getFileSize(), stats.getEntriesWritten()),
commitSession,
flushId);
- compactable.filesAdded(true, List.of(storedFile));
+ storedFile.ifPresent(stf -> compactable.filesAdded(true,
List.of(stf)));
Review comment:
Yes. A NPE would be thrown. I don't know if it affected anything with
compactions since it only happens when no file gets written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
