keith-turner commented on a change in pull request #2342:
URL: https://github.com/apache/accumulo/pull/2342#discussion_r745891296
##########
File path:
test/src/main/java/org/apache/accumulo/test/functional/FunctionalTestUtils.java
##########
@@ -218,4 +221,34 @@ private static FateStatus getFateStatus(ClientContext
context, AccumuloCluster c
throw new RuntimeException(e);
}
}
+
+ /**
+ * Verify that flush ID gets updated properly and is the same for all
tablets.
+ */
+ static long checkFlushId(ClientContext c, TableId tableId, long prevFlushID)
throws Exception {
+ try (var metaScan =
c.getAmple().readTablets().forTable(tableId).fetch(FLUSH_ID).build()) {
Review comment:
Realized one more thing, I think this may only return tablets were the
column is present. If a tablet didn't have this column, then it may not even
show up (like there would not even be tablet metadata entry of not present).
Because we are only fetching the flush_id column in the underly scan, tablet
w/o that column do not show up. Adding the check consistency will make it
fetch the prev row col also which will make tablets w/o the column visible.
Also get the benefit of ensure the tablets are consistent.
```suggestion
try (var metaScan =
c.getAmple().readTablets().forTable(tableId).fetch(FLUSH_ID).checkConsistency().build())
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]