ctubbsii opened a new pull request #2363:
URL: https://github.com/apache/accumulo/pull/2363
* Remove client-side properties and server-side property to set
OpenTelemetry factory. This isn't needed because:
* For server-side, we only need to use the GlobalOpenTelemetry
instance, and that can be overridden by standard means in
OpenTelemetry (class path setup for autoconfigure instance or
javaagent to inject a custom impl)
* For client-side, we can assume it is on by default and the user can
set their own GlobalOpenTelemetry instance (or set it up with class
path for autoconfigure or use javaagent to inject)
* Remove no longer used SPI
* Rename some TraceUtil methods to ensure they are used properly
* Update TraceUtil to simplify initialization on the server-side using a
single boolean, that can also be enabled/disabled easily for the Shell
using the Shell's TraceCommand (enabled just means it will use the
GlobalOpenTelemetry instance, which is typically the autoconfigured
one, and disabled means it will use the NOOP explicitly, even if the
GlobalOpenTelemetry instance is set)
* Short-circuit span creation using an invalid span singleton if tracing
is disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
