ctubbsii commented on a change in pull request #2363:
URL: https://github.com/apache/accumulo/pull/2363#discussion_r754550047
##########
File path: core/src/main/java/org/apache/accumulo/core/trace/TraceUtil.java
##########
@@ -56,97 +52,32 @@
private static final String SPAN_FORMAT = "%s::%s";
- private static Tracer instance = null;
- private static boolean tracing = false;
+ private static volatile boolean enabled = true;
- private static void initializeInternals(OpenTelemetry ot) {
- instance = ot.getTracer(APPNAME, VERSION);
- tracing = !ot.equals(OpenTelemetry.noop());
- LOG.info("Trace enabled: {}, OpenTelemetry instance: {}, Tracer instance:
{}", tracing,
- ot.getClass(), instance.getClass());
+ public static void initializeTracer(AccumuloConfiguration conf) {
+ enabled = conf.getBoolean(Property.GENERAL_OPENTELEMETRY_ENABLED);
+ LOG.info("Trace enabled: {}, OpenTelemetry instance: {}, Tracer instance:
{}", enabled,
Review comment:
Consolidated log message handling in
8128c11a7a841756e056e229ef01cf26f9b85f86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
