dlmarion commented on issue #2350: URL: https://github.com/apache/accumulo/issues/2350#issuecomment-982601335
@milleruntime - what's the error here? How do you think it should be handled differently? I have reviewed the code and the error originates [here](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java#L238) when trying to close the compaction output file. The error is re-thrown which affects both the internal and external compaction code. In the internal compaction case, it bubbles up to [here](https://github.com/apache/accumulo/blob/main/server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/InternalCompactionExecutor.java#L100) and a warning is logged. In the external case the error bubbles up [here](https://github.com/apache/accumulo/blob/main/server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java#L569). I could remove the line that throws a RuntimeException from the thread, that would remove the log entry for the UncaughtExceptionHandler saying the thread is dead. I th ink the code would be unaffected by doing that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
