milleruntime commented on a change in pull request #2372:
URL: https://github.com/apache/accumulo/pull/2372#discussion_r763209525
##########
File path:
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java
##########
@@ -184,7 +184,7 @@ protected void
startCancelChecker(ScheduledThreadPoolExecutor schedExecutor,
TimeUnit.MILLISECONDS);
}
- protected void checkIfCanceled() {
+ protected synchronized void checkIfCanceled() {
Review comment:
I noticed the `cancel()` method call on `CompactionJobHolder` is
synchronized, so maybe that is enough. Could add another check to this method
to see if the compactionThread is already interrupted so we don't keep calling
interrupt while waiting for the thread to die.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
