keith-turner commented on a change in pull request #2372:
URL: https://github.com/apache/accumulo/pull/2372#discussion_r763268668
##########
File path:
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java
##########
@@ -184,7 +184,7 @@ protected void
startCancelChecker(ScheduledThreadPoolExecutor schedExecutor,
TimeUnit.MILLISECONDS);
}
- protected void checkIfCanceled() {
+ protected synchronized void checkIfCanceled() {
Review comment:
> I noticed the cancel() method call on CompactionJobHolder is
synchronized, so maybe that is enough.
I think the existing sync in CompactionJobHolder will prevent any race
conditions from happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
