milleruntime commented on a change in pull request #2425:
URL: https://github.com/apache/accumulo/pull/2425#discussion_r790770655
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
##########
@@ -253,8 +254,10 @@ public TabletServerResourceManager(ServerContext context) {
final AccumuloConfiguration acuConf = context.getConfiguration();
long maxMemory = acuConf.getAsBytes(Property.TSERV_MAXMEM);
- boolean usingNativeMap =
- acuConf.getBoolean(Property.TSERV_NATIVEMAP_ENABLED) &&
NativeMap.isLoaded();
+ boolean usingNativeMap =
acuConf.getBoolean(Property.TSERV_NATIVEMAP_ENABLED);
+ if (usingNativeMap) {
+ NativeMapLoader.load();
Review comment:
I was suggesting removing the static load block from `NativeMap` and
keeping this fast failure check in the tserver. Why do we still need the static
code block in `NativeMap`, if we are resolving at the start up of tserver? I
thought we may be using `NativeMap` outside of the tserver, perhaps in a scan
thread or somewhere but couldn't find any other references. My point was we
don't need the static code block with this new check. Sorry I should have
commented on that part of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
