ctubbsii commented on a change in pull request #2425:
URL: https://github.com/apache/accumulo/pull/2425#discussion_r791684454
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/NativeMap.java
##########
@@ -70,120 +66,9 @@
public class NativeMap implements Iterable<Map.Entry<Key,Value>> {
private static final Logger log = LoggerFactory.getLogger(NativeMap.class);
- private static AtomicBoolean loadedNativeLibraries = new
AtomicBoolean(false);
- // Load native library
static {
Review comment:
I didn't add a new fast fail check. There was already a static reference
to the `NativeMap` class in there before my changes. I preserved the existing
behavior by explicitly adding the load there. However, it I remove this here,
then it wouldn't guarantee that it was loaded before this class could be
referenced, which some code could do in the future. Keeping this static
initializer block and making the explicit load in the resources class for fast
failure preserves all existing behaviors, which I don't want to risk changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
