ctubbsii commented on a change in pull request #2427:
URL: https://github.com/apache/accumulo/pull/2427#discussion_r792955737
##########
File path:
core/src/test/java/org/apache/accumulo/core/client/ZooKeeperInstanceTest.java
##########
@@ -128,33 +129,33 @@ public void testGetInstanceID_Direct() {
assertEquals(IID_STRING, zki.getInstanceID());
}
- @Test(expected = RuntimeException.class)
+ @Test
public void testGetInstanceID_NoMapping() {
ClientConfiguration config = createMock(ClientConfiguration.class);
expect(zc.get(Constants.ZROOT + Constants.ZINSTANCES +
"/instance")).andReturn(null);
replay(zc);
EasyMock.reset(config, zcf);
- new ZooKeeperInstance(config, zcf);
+ assertThrows(RuntimeException.class, () -> new ZooKeeperInstance(config,
zcf));
Review comment:
Yes. These would be good to have first. Then, you can rebase this onto
that, in order to make this migration smaller and easier to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
