ctubbsii edited a comment on pull request #2427: URL: https://github.com/apache/accumulo/pull/2427#issuecomment-1022535919
> > This is going to get _really_ big. So, instead of adding all the changes to one single big PR, which is a nightmare for code review, let's split this across a couple different PRs, so we can make sure that each incremental update still works before we move on to the next one. > > That sounds like a good idea. Do you have anything in mind for how we might split this task up? Maybe Each module? Tasks can be grouped into: 1. things that can be done while still on JUnit4 to ease the migration 2. things to update the parent POM to manage the JUnit dependencies 3. (module migration stage 1) things that can be done in each module to move that module from JUnit4 to JUnit5 with the vintage engine 4. (module migration stage 2) things that can be done in each module to move that module from JUnit5 vintage to JUnit5 jupiter engine The first item can definitely be done in its own PR. The last two can be broken up a few different ways, depending. Like, you could do item 3 for all modules in one PR, then do separate PRs for each module (or a couple modules at a time, if they are small enough to be manageable for a review) for item 4. For item 2, you can probably include that in your first PR that does any JUnit5 stuff. Feel free to break it up however you think best. The goal in breaking it up is to help streamline code reviews and make incremental progress without breaking anything. You could keep a table to track the migration: | Module | Migrate to JUnit5 vintage | Migrate to JUnit5 jupiter | | ----------- | ----------- | ----------- | | assemble | ☑ | ☑ | | core | ☑ | ☑ | | hadoop-mapreduce | ☑ | | | iterator-test-harness | ☑ | | | minicluster | ☑ | | | server/base | ☑ | | | server/compaction-coordinator | ☑ | | | server/compactor | ☑ | | | server/gc | ☑ | | | server/manager | ☑ | | | server/master | ☑ | | | server/monitor | ☑ | | | server/native | ☑ | | | server/tserver | ☑ | | | shell | ☑ | | | start | ☑ | | | test | | | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
