DomGarguilo edited a comment on issue #2441: URL: https://github.com/apache/accumulo/issues/2441#issuecomment-1049133153
I wanted to bring up another case that could be standardized while converting to JUnit5. The new `@Timeout` annotation which can be specified per class or per method has a default unit of seconds (e.g. `@Timeout(42)` would be 42 seconds). There is an optional parameter that can be added to specify units (e.g. `@Timeout(value = 42, unit = MINUTES)` would be 42 minutes). [See the docs for more details](https://junit.org/junit5/docs/current/api/org.junit.jupiter.api/org/junit/jupiter/api/Timeout.html). Currently, the ITs specify a timeout in seconds, usually doing something like `5 * 60` to specify minutes (5 mins in this case). My question is, should we keep everything standard and continue using seconds for all timeouts or, when it makes sense, use the unit parameter (e.g. to specify a 5 minute timeout, instead of `@Timeout(5 * 60)` should we use `@Timeout(value = 5, unit = MINUTES)`). This is pretty small but there are a lot of occurrences so I thought I would get some opinions before I convert them all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
