DomGarguilo commented on issue #2441: URL: https://github.com/apache/accumulo/issues/2441#issuecomment-1050166774
I'm running into some issues getting the timeouts configured with JUnit 5 `@Timeout`. Currently, for ITs, there is a default timeout that is set in `AccumuloITBase` and then can be altered with a timeout factor that can be supplied as an argument when running the tests in terminal. All tests that extend `AccumuloITBase` have this timeout applied to them via the `@Rule`. The code for this is here: https://github.com/apache/accumulo/blob/f8ec16c833ad7b58759a9101e4d9befd524b9daf/test/src/main/java/org/apache/accumulo/harness/AccumuloITBase.java#L101-L122 The `Timeout` object and `@Rule` are no longer present in JUnit5. As far as I can tell, there are ways to set a global timeout to tests(via [Configuration Parameters](https://junit.org/junit5/docs/current/user-guide/#running-tests-config-params)), but the issue I'm running into is how to incorporate the timeout factor that is used to scale the timeouts. The `@Timeout` annotations need to be set per class and will not apply to child classes. The value for `@Timeout`s can be set to a variable but it needs to be a constant meaning we cannot set the timeout to something like `final static int TIMEOUT = 600 * getTimeoutFactor()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
