keith-turner commented on a change in pull request #2530:
URL: https://github.com/apache/accumulo/pull/2530#discussion_r816050304
##########
File path:
core/src/main/java/org/apache/accumulo/core/util/threads/AccumuloUncaughtExceptionHandler.java
##########
@@ -32,11 +32,40 @@
private static final Logger LOG =
LoggerFactory.getLogger(AccumuloUncaughtExceptionHandler.class);
+ static boolean isError(Throwable t, int depth) {
+
+ if (depth > 32) {
+ // This is a peculiar exception. No error has been found, but recursing
too deep may cause a
+ // stack overflow so going to stop.
+ return false;
Review comment:
@dlmarion and @ctubbsii since this method recurses, I added this depth
check to defend against stack overflow (I also added a test that exercises this
code). I was not sure sure if this should return true or false when its
inconclusive like this. I finally settled on false, but still not sure. Any
votes for returning true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
