ctubbsii commented on pull request #2568: URL: https://github.com/apache/accumulo/pull/2568#issuecomment-1068553396
Responding to self: > However, I'm not sure why that is necessary. I think this might have been written by @keith-turner , so perhaps he has some insight on why these must not block. I was in a rush when I sent my earlier comment, so I'm not sure I was clear. Unless there's a really good reason, I'd be okay with making close block to dramatically simplify this code. I don't think that would be a problem because, if a user wanted a scanner to close in the background, they could always do that themselves. If that was the case, then correctness and resource management for that background close would be their responsibility. That said, I think this PR is sufficient for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
