EdColeman commented on a change in pull request #2569:
URL: https://github.com/apache/accumulo/pull/2569#discussion_r828289245
##########
File path:
core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java
##########
@@ -597,4 +599,13 @@ public T derive() {
* this configuration.
*/
public void invalidateCache() {}
+
+ /**
+ * get a parent configuration or null if it does not exist.
+ *
+ * @since 2.1.0
+ */
+ public AccumuloConfiguration getParent() {
+ return null;
Review comment:
Sub-classes that extend AccumuloConfiguration that have a hierarchy,
override this method to return a parent - for ones that are stand alone (like
DefaultConfiguration and ConfigurationCopy) then there is no hierarchy and null
is appropriate. The alternative would be to declare the method abstract and
force each sub-class to provide an implementation. So the null is appropriate,
it just depends on where the responsibility for returning null is implemented.
Here, or the sub-classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
