EdColeman commented on a change in pull request #2569:
URL: https://github.com/apache/accumulo/pull/2569#discussion_r828418079
##########
File path:
core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java
##########
@@ -160,15 +160,17 @@ public long getUpdateCount() {
PrefixProps prefixProps = cachedPrefixProps.get(property);
- if (prefixProps == null || prefixProps.updateCount != getUpdateCount()) {
+ long currentCount = getUpdateCount();
+
+ if (prefixProps == null || prefixProps.updateCount != currentCount) {
prefixCacheUpdateLock.lock();
try {
// Very important that update count is read before getting properties.
Also only read it
// once.
- long updateCount = getUpdateCount();
+ long startCount = getUpdateCount();
Review comment:
The name change was held over from a previous approach where a start /
end check was used. will change it back.
I think it would more difficult to isolate changes that occurred because of
IDE recommendations than reviewing them in this context. The changes should be
easy to determine that they remain correct (or not) and it seems that it would
be just as fast / easy to review them once rather than 2 PRs that are changing
essentially the same files. But that's my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
