ctubbsii commented on PR #2622: URL: https://github.com/apache/accumulo/pull/2622#issuecomment-1095884144
@nikita-sirohi Thanks for the explanation! It helps a lot. (Note: I updated your markdown blocks in your comment above, so it looks better... in case you were curious why I edited your comment.) I'll have to see where this pattern is being used elsewhere... it feels wrong, but if it's being done that elsewhere, I'm curious why. Ideally, if we know that this can manifest as `ClosedByInterruptException` when opening a socket, we should probably have a separate catch block just for that to handle it differently than other `IOException`s, so we don't retry forever and maybe the interrupt exception gets propagated instead. I'm not sure I understand what you mean about `wasn't sure if either createClientTransport or TTimeoutTransport.create had the appropriate information to special case this exception`, but I suspect this will be obvious if we try to handle it differently. I'm not familiar with trino. What circumstance with that caused you to see this? Does it just have a command-line interface and you hit `Ctrl+C` while it was opening a socket? Or does it interrupt Accumulo threads routinely by some other mechanism? I know I haven't seen this very often... these threads don't normally get interrupted while opening sockets, so this is a very strange edge case for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
