ctubbsii commented on code in PR #2622:
URL: https://github.com/apache/accumulo/pull/2622#discussion_r857900245
##########
server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java:
##########
@@ -527,6 +529,12 @@ public static ServerAddress
createSaslThreadPoolServer(HostAndPort address, TPro
serverUser = UserGroupInformation.getLoginUser();
} catch (IOException e) {
transport.close();
Review Comment:
Can this close trigger its own IOException?
##########
core/src/main/java/org/apache/accumulo/core/rpc/TTimeoutTransport.java:
##########
@@ -100,6 +103,12 @@ TTransport createInternal(SocketAddress addr, long
timeoutMillis) throws TTransp
return new TIOStreamTransport(input, output);
} catch (IOException e) {
closeSocket(socket, e);
Review Comment:
Can this closeSocket trigger its own IOException?
##########
core/src/main/java/org/apache/accumulo/core/rpc/TTimeoutTransport.java:
##########
@@ -18,14 +18,11 @@
*/
package org.apache.accumulo.core.rpc;
-import java.io.BufferedInputStream;
-import java.io.BufferedOutputStream;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.OutputStream;
+import java.io.*;
Review Comment:
Our style does not permit use of wildcard imports.
Please use individual imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
