ctubbsii commented on code in PR #2672: URL: https://github.com/apache/accumulo/pull/2672#discussion_r865047445
########## server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java: ########## @@ -206,6 +212,7 @@ private void confirmDeletes(GarbageCollectionEnvironment gce, confirmDeletesFromReplication(gce.getReplicationNeededIterator(), candidateMap.entrySet().iterator()); + return blipCount; } protected void confirmDeletesFromReplication( Review Comment: A grep for 'replication' is just as good as a grep for 'deprecated', and avoiding the deprecated annotation means less warnings suppression annotations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org