[GitHub] [accumulo] milleruntime commented on a diff in pull request #2672: Add new blip count to GC

[GitBox]

milleruntime commented on code in PR #2672:
URL: https://github.com/apache/accumulo/pull/2672#discussion_r865799736


##########
server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectionTest.java:
##########
@@ -622,15 +622,16 @@ public void test() throws Exception {
     gce.candidates.clear();
     gce.candidates.add("/9/default_tablet");
     gce.candidates.add("/9/default_tablet/someFile");
-    gca.collect(gce);
+    long blipCount = gca.collect(gce);
     assertRemoved(gce);
+    assertEquals(0, blipCount);
 
     gce = new TestGCE();
     gce.blips.add("/1636/b-0001");
     gce.candidates.add("/1636/b-0001/I0000");
-    gca.collect(gce);
+    blipCount = gca.collect(gce);
     assertRemoved(gce);
-
+    assertEquals(1, blipCount);

Review Comment:
   Yeah I can add another test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org