keith-turner commented on code in PR #2665:
URL: https://github.com/apache/accumulo/pull/2665#discussion_r865172579


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftScanner.java:
##########
@@ -358,7 +380,22 @@ else if (log.isTraceEnabled())
           }
 
           TraceUtil.setException(child2, e, false);
-          sleepMillis = pause(sleepMillis, maxSleepTime);
+          sleepMillis = pause(sleepMillis, maxSleepTime, 
scanState.runOnScanServer);
+        } catch (ScanServerBusyException e) {
+          error = "Scan failed, scan server was busy " + loc;

Review Comment:
   While testing I encountered an exception on the scan server.  The error 
message on the client side indicated there was an error on the tserver.  That 
is because this loc is the tserver.  The code that generated the error message 
I saw is further up, it was from the following line.
   
   ```
   throw new AccumuloServerException(loc.tablet_location, tae);
   ```
   
   All of the catch blocks in this try that use the loc may have have the same 
problem.  We may be able to use `scanState.prevLoc` instead of loc as this is 
always set to the actual server before making the rpc call.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to