dlmarion commented on code in PR #2691:
URL: https://github.com/apache/accumulo/pull/2691#discussion_r870230176


##########
server/base/src/main/java/org/apache/accumulo/server/conf/store/impl/PropCacheCaffeineImpl.java:
##########
@@ -130,13 +135,18 @@ public Builder(final ZooPropLoader zooPropLoader, final 
PropStoreMetrics metrics
     }
 
     public PropCacheCaffeineImpl build() {
-      return new PropCacheCaffeineImpl(zooPropLoader, metrics, ticker);
+      return new PropCacheCaffeineImpl(zooPropLoader, metrics, ticker, 
runTasksInline);
     }
 
     public Builder withTicker(final Ticker ticker) {
       this.ticker = ticker;
       return this;
     }
+
+    public Builder forTests() {

Review Comment:
   I thought about this, but I noticed that `withTicker` is used outside of the 
tests, in the `ZooPropStore` constructor. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to