EdColeman commented on code in PR #2691:
URL: https://github.com/apache/accumulo/pull/2691#discussion_r870257677
##########
server/base/src/test/java/org/apache/accumulo/server/conf/store/impl/ZooPropLoaderTest.java:
##########
@@ -548,14 +543,13 @@ public void refreshSameVersionTest() throws Exception {
replay(context, zrw, propStoreWatcher, cacheMetrics, mockProps);
- PropCacheCaffeineImpl cache = new PropCacheCaffeineImpl.Builder(loader,
cacheMetrics)
- .withTicker(ticker).forTests().build();
+ PropCacheCaffeineImpl cache =
+ new PropCacheCaffeineImpl.Builder(loader,
cacheMetrics).forTests(ticker).build();
// prime cache
cache.get(propCacheKey);
ticker.advance(30, TimeUnit.MINUTES);
- cache.cleanUp();
Review Comment:
Why is this being removed? The test is going to rely on the cache cleaner
thread ran,
##########
test/src/main/java/org/apache/accumulo/test/conf/store/ZooBasedConfigIT.java:
##########
@@ -371,24 +360,4 @@ public String toString() {
}
}
- private static class TestTicker implements Ticker {
Review Comment:
I don't think this should be removed - a fake timer is necessary to exercise
the functionally in the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
