ctubbsii commented on PR #2717: URL: https://github.com/apache/accumulo/pull/2717#issuecomment-1134933878
> Instead of adding a method to `InstanceOperations` what about adding a static method to the new `Accumulo` entry point? We could develop a fluent API, similar to what we did with the `newClientProperties()` method. A full on fluent API for mutating/building system properties is a bit overkill. It was why I was originally thinking we'd want to just support a primitive replace operation. However, with the Consumer idea, we can get all the benefits of having a full-fledged mutate API, but all in a single method, without any bloat. As for the static method, with a separate entry point, I'm not sure that would be helpful at all, because the properties are already tied to an instance, like the current setProperty and removeProperty are. After this, we're also going to want to add similar features for table and namespace operations. So, I don't think it makes sense to put the entry point for this as a static method on the `Accumulo` entry point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
