cshannon commented on PR #2717:
URL: https://github.com/apache/accumulo/pull/2717#issuecomment-1172959006

   Looks like this actually still needs some more work as it only address 
`InstanceOperations` and not `NamespaceOperations` and `TableOperations` so I'm 
working on cleaning up the code and then adding those implementations and tests.
   
   @ctubbsii - I'm going through the history of the PR and just wanted to get 
one clarification and make sure I'm on the same page. It seems like based on 
the comments the intent here of the modifyProperties(mapMutator) is to also 
delete and not just modify/add to the existing properties.  This would imply 
any properties that currently exist in the config (for the given PropStoreKey) 
but are no longer included in the mutated map after the mapMutator handles the 
properties map should be deleted which makes sense to me. Correct?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to