dlmarion commented on code in PR #2750:
URL: https://github.com/apache/accumulo/pull/2750#discussion_r888165252
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -635,31 +637,34 @@ private void deleteTablets(MergeInfo info) throws
AccumuloException {
ServerColumnFamily.TIME_COLUMN.fetch(scanner);
scanner.fetchColumnFamily(DataFileColumnFamily.NAME);
scanner.fetchColumnFamily(CurrentLocationColumnFamily.NAME);
- Set<String> datafiles = new TreeSet<>();
+ Set<Reference> datafilesAndDirs = new TreeSet<>();
Review Comment:
My suggestion would be to implement `hashCode`, `equals` and `Comparable` on
each Reference class. Then for this TreeSet, provide a Comparator that uses
only the metadata entry to maintain backwards compatibility, the old code is
just comparing Strings (which I assume are the metadata entry now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
