dlmarion commented on code in PR #2750:
URL: https://github.com/apache/accumulo/pull/2750#discussion_r892263409
##########
core/src/main/java/org/apache/accumulo/core/metadata/Reference.java:
##########
@@ -38,4 +38,28 @@ public Reference(TableId tableId, String metadataEntry) {
this.metadataEntry = metadataEntry;
this.tabletDir = metadataEntry;
}
+
+ @Override
+ public int compareTo(Reference that) {
+ if (equals(that)) {
+ return 0;
+ } else {
+ return this.metadataEntry.compareTo(that.metadataEntry);
+ }
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (obj instanceof Reference) {
+ Reference that = (Reference) obj;
+ return this.metadataEntry.equals(that.metadataEntry);
+ } else {
+ return false;
+ }
+ }
Review Comment:
So you are saying that Reference and it's subclasses are *not* used as file
references in the metadata table? I got confused by the class locations /
packages / names and the other issues that you referenced with prior changes.
If that's the case, then can we move these classes out of core and into the GC
module. If not, at the very least, can we change their package. It would appear
that these classes are used in the metadata table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
