milleruntime commented on code in PR #2767: URL: https://github.com/apache/accumulo/pull/2767#discussion_r898095967
########## core/src/main/java/org/apache/accumulo/core/gc/ReferenceFile.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.gc; + +import org.apache.accumulo.core.data.TableId; +import org.apache.accumulo.core.metadata.schema.MetadataSchema; + +/** + * A GC reference used for streaming and delete markers. This type is a file. Subclass is a + * directory. + */ +public class ReferenceFile implements Reference, Comparable<ReferenceFile> { + // parts of an absolute URI, like "hdfs://1.2.3.4/accumulo/tables/2a/t-0003" + public final TableId tableId; // 2a + + // the exact string that is stored in the metadata + public final String metadataEntry; + + public ReferenceFile(TableId tableId, String metadataEntry) { + MetadataSchema.TabletsSection.ServerColumnFamily.validateDirCol(tableId.canonical()); + this.tableId = tableId; + this.metadataEntry = metadataEntry; + } + + @Override + public boolean isDirectory() { + return false; + } + + @Override + public TableId getTableId() { + return tableId; + } + + @Override + public String getMetadataEntry() { + return metadataEntry; + } + + @Override + public int compareTo(ReferenceFile that) { + if (equals(that)) { + return 0; + } else { + return this.metadataEntry.compareTo(that.metadataEntry); Review Comment: Yes but the main spot where the collection is created is in the deleteTablets() method in `TabletGroupWatcher`: https://github.com/apache/accumulo/blob/cf57e343de77f416de10c22e0ed05ef37f433b36/server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java#L639 From there the GC method `putGcFileAndDirCandidates()` gets called. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
