[GitHub] [accumulo] milleruntime commented on a diff in pull request #2767: Create Reference interface for new GC classes

[GitBox]

milleruntime commented on code in PR #2767:
URL: https://github.com/apache/accumulo/pull/2767#discussion_r899027521


##########
server/base/src/main/java/org/apache/accumulo/server/gc/GcVolumeUtil.java:
##########
@@ -24,20 +24,20 @@
 
 import org.apache.accumulo.core.Constants;
 import org.apache.accumulo.core.data.TableId;
-import org.apache.accumulo.core.gc.Reference;
 import 
org.apache.accumulo.core.metadata.schema.MetadataSchema.TabletsSection.ServerColumnFamily;
 import org.apache.accumulo.server.fs.VolumeManager;
 import org.apache.hadoop.fs.Path;
 
 public class GcVolumeUtil {
   // AGCAV : Accumulo Garbage Collector All Volumes
-  private static final String ALL_VOLUMES_PREFIX = "agcav:/";
+  static final String ALL_VOLUMES_PREFIX = "agcav:/";
 
-  public static Reference getDeleteTabletOnAllVolumesUri(TableId tableId, 
String dirName) {
+  public static AllVolumesDirectory getDeleteTabletOnAllVolumesUri(TableId 
tableId,

Review Comment:
   Yeah. I moved it in 
https://github.com/apache/accumulo/pull/2767/commits/4818a62962c1186d313072eeb14aa0345f10f50b



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org