keith-turner commented on code in PR #2792:
URL: https://github.com/apache/accumulo/pull/2792#discussion_r972860972
##########
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionEnvironment.java:
##########
@@ -72,6 +72,17 @@ public interface GarbageCollectionEnvironment {
*/
Stream<Reference> getReferences();
+ /**
+ * Return a list of all TableIDs in the
+ * {@link org.apache.accumulo.core.metadata.schema.Ample.DataLevel} for
which we are considering
+ * deletes. When operating on DataLevel.USER this will return all user table
ids. When operating
+ * on DataLevel.METADATA this will return the table id for the
accumulo.metadata table. When
+ * operating on DataLevel.ROOT this will return the table id for the
accumulo.root table.
+ *
+ * @return The table ids
+ */
+ Set<TableId> getCandidateTableIDs();
Review Comment:
Maybe its confusing because it goes more with
`GCRun.getCandidateTableIDs()`. Could do the following to make it less
confusing.
* Move the current javadoc on the interface to
`GCRun.getCandidateTableIDs()` and replace `when operating on` with `the
current data level is`
* Update the javadoc on this interface to make it generic like : `Return a
set of all TableIDs that should be seen in {@link #getReferences()} at the
current time. Immediately after this method returns the information it
produced may be out of date relative to {@link #getReferences()} ... {@see
GCRun#getCandidateTableIDs}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
