dlmarion commented on code in PR #2792:
URL: https://github.com/apache/accumulo/pull/2792#discussion_r973225860
##########
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##########
@@ -462,4 +479,20 @@ public long getErrorsStat() {
public long getCandidatesStat() {
return candidates;
}
+
+ @Override
+ public Set<TableId> getCandidateTableIDs() {
+ if (level == DataLevel.ROOT) {
+ return Set.of(RootTable.ID);
+ } else if (level == DataLevel.METADATA) {
+ return Collections.singleton(MetadataTable.ID);
+ } else if (level == DataLevel.USER) {
+ Set<TableId> tableIds = new HashSet<>(getTableIDs());
+ tableIds.remove(MetadataTable.ID);
+ tableIds.remove(RootTable.ID);
+ return tableIds;
+ } else {
+ throw new RuntimeException("Unexpected Table in GC Env: " +
this.level.name());
Review Comment:
Addressed in 1f8d37305789fa1540158e32b54da86a7af3ae87
##########
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java:
##########
@@ -135,10 +137,14 @@ private SortedMap<String,String>
makeRelative(Collection<String> candidates) {
private void removeCandidatesInUse(GarbageCollectionEnvironment gce,
SortedMap<String,String> candidateMap) {
+
+ Set<TableId> tableIdsBefore = gce.getCandidateTableIDs();
+ Set<TableId> tableIdsSeen = new HashSet<>();
var refStream = gce.getReferences();
Iterator<Reference> iter = refStream.iterator();
while (iter.hasNext()) {
Reference ref = iter.next();
+ tableIdsSeen.add(ref.getTableId());
Review Comment:
Addressed in 1f8d37305789fa1540158e32b54da86a7af3ae87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
