EdColeman commented on code in PR #2986:
URL: https://github.com/apache/accumulo/pull/2986#discussion_r984552973


##########
core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java:
##########
@@ -93,6 +93,15 @@ void modifyProperties(Consumer<Map<String,String>> 
mapMutator) throws AccumuloEx
    */
   Map<String,String> getSystemConfiguration() throws AccumuloException, 
AccumuloSecurityException;
 
+  /**
+   * Retrieves the stored System properties from zookeeper. This method is 
different from
+   * {@link #getSystemConfiguration()} as it will only return the stored 
properties in zookeeper and
+   * not properties from accumulo.properties or default values..
+   *
+   * @return a map of stored system properties set in zookeeper
+   */
+  Map<String,String> getStoredProperties() throws AccumuloException, 
AccumuloSecurityException;

Review Comment:
   1) If I have shell access that is different from needing access to read 
files on a system.
   2) There is a hash check that checks properties have the same critical 
values so there is a good probability that an active tserver has properties 
that match across the cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to