EdColeman commented on code in PR #2986:
URL: https://github.com/apache/accumulo/pull/2986#discussion_r984519851
##########
core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java:
##########
@@ -93,6 +93,15 @@ void modifyProperties(Consumer<Map<String,String>>
mapMutator) throws AccumuloEx
*/
Map<String,String> getSystemConfiguration() throws AccumuloException,
AccumuloSecurityException;
+ /**
+ * Retrieves the stored System properties from zookeeper. This method is
different from
+ * {@link #getSystemConfiguration()} as it will only return the stored
properties in zookeeper and
+ * not properties from accumulo.properties or default values..
+ *
+ * @return a map of stored system properties set in zookeeper
+ */
+ Map<String,String> getStoredProperties() throws AccumuloException,
AccumuloSecurityException;
Review Comment:
Stored or something equivalent seems to point in the correct direction -
they would need to look at the documentation to find out what the difference
between `getSystemConfiguration` and `getSystemProperies` difference is anyway
- not having it named properties in the code (too me) increases clarity because
properties and configuration seem to be easily confused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
