cshannon opened a new pull request, #3064: URL: https://github.com/apache/accumulo/pull/3064
This PR has 3 initial commits to show the different changes easier. It is currently a draft PR to get feedback on the new styling and any changes/tweaks before merging as it would be a very large change. If we want to move forward with this we would likely need to make sure there were no major outstanding things to merge as that would make merging things difficult. 1. The first one updates the maven formatter plugin to use the [Google Java Style ](https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml)guide. The xml file was added to the code base with a minor modification (doesn't format headers since there is a header formatter plugin for that). The file is licensed under Apache 2.0. 2. The second commit makes missing curly braces for control statements a warning for error prone. 3. The last commit is huge and reformats everything, this required using the IDE to fix the curly braces and then running the build to update the formatting. This can be easily regenerated by use the IDE maven build. **Note:** I left the checkstyle configuration alone for now. There is a checkstyle guide that matches the Google Java Style located [here](https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml) but the problem is it is LGPL v2.1 which I believe is not compatible with Apache 2.0 license -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
