cshannon commented on PR #3064: URL: https://github.com/apache/accumulo/pull/3064#issuecomment-1303835237
@ctubbsii - Ok I force pushed up changes and got rid of the reformat commit. So the issue is the two xml files are vastly different due to ordering of the xml tags and the changes are huge as you will see. Since they were not in the same order it was impossible to view the real differences. To make it easier to attempt to review the differences I ran the old version of the file through the sort command and committed that first. Then I updated the file with the new google style (kept the same file name for now but can always rename it to make comparison easier) and sorted that and pushed up a second commit. The third commit is still errorpone. So if you compare commit 2 to commit 1 by itself you can see the main differences between the codestyles. Let me know if you can think of a better way but this seemed like the simplest way to compare. I could also sort the original codestyle file first in another PR and merge that into main and then based this PR off that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
