ctubbsii commented on code in PR #3083:
URL: https://github.com/apache/accumulo/pull/3083#discussion_r1027114280
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -964,6 +964,11 @@ public enum Property {
"1.3.5"),
TABLE_ARBITRARY_PROP_PREFIX("table.custom.", null, PropertyType.PREFIX,
"Prefix to be used for user defined arbitrary properties.", "1.7.0"),
+ TABLE_MAJC_OUTPUT_DROP_CACHE("table.compaction.major.output.drop.cache",
"false",
+ PropertyType.BOOLEAN,
+ "Setting this property to true will call"
+ + "FSDataOutputStream.setDropBehind(true) on the major compaction
output stream.",
+ "2.1.1"),
Review Comment:
@dlmarion The arbitrary properties are intended to be a namespace for
storage of properties for user-pluggable components, not for builtin framework
configurations. For example, setting the volume chooser class is a builtin
configuration, but some volume choosers may make use of arbitrary properties to
control their behavior. I don't think that situation applies here. My
understanding is that FileCompactor is a builtin component, part of the
compaction framework, and not a user-pluggable component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
