keith-turner commented on code in PR #3083:
URL: https://github.com/apache/accumulo/pull/3083#discussion_r1029095012
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -964,6 +964,11 @@ public enum Property {
"1.3.5"),
TABLE_ARBITRARY_PROP_PREFIX("table.custom.", null, PropertyType.PREFIX,
"Prefix to be used for user defined arbitrary properties.", "1.7.0"),
+ TABLE_MAJC_OUTPUT_DROP_CACHE("table.compaction.major.output.drop.cache",
"false",
+ PropertyType.BOOLEAN,
+ "Setting this property to true will call"
+ + "FSDataOutputStream.setDropBehind(true) on the major compaction
output stream.",
+ "2.1.1"),
Review Comment:
> I'm not sure why the CompactionConfigurer class isn't in the SPI package.
@dlmarion I think there were two reasons its ended up in API instead of SPI.
First its referenced from the user compaction APIs. Second it can deal with
user data (like deciding to compress compaction output with a certain
algorithm). I think all of the compaction interfaces in the SPI only deal with
execution of compactions and do not influence the data produced. When an
interface is related to user data it may be good to place it in API rather than
SPI to give more stability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
