ctubbsii commented on code in PR #3109:
URL: https://github.com/apache/accumulo/pull/3109#discussion_r1042973086
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java:
##########
@@ -165,8 +165,10 @@ private void validateACLs(ServerContext context) {
if (((path.equals(Constants.ZROOT) || path.equals(Constants.ZROOT +
Constants.ZINSTANCES))
&& !acls.equals(ZooDefs.Ids.OPEN_ACL_UNSAFE))
- || (!privateWithAuth.equals(acls) &&
!publicWithAuth.equals(acls))) {
- log.error("ZNode at {} has unexpected ACL: {}", path, acls);
+ || (!acls.containsAll(privateWithAuth) &&
!acls.containsAll(publicWithAuth))) {
Review Comment:
Do we really want to change from a set-equality to a set-inclusion check? If
so, we won't log an error if the node's permissions are wide-open with
extraneous unexpected permissions. I'm not sure that is the intent here. Should
we do an order-independent set-equality check instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
