ctubbsii commented on code in PR #3109:
URL: https://github.com/apache/accumulo/pull/3109#discussion_r1048798075
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java:
##########
@@ -165,8 +165,10 @@ private void validateACLs(ServerContext context) {
if (((path.equals(Constants.ZROOT) || path.equals(Constants.ZROOT +
Constants.ZINSTANCES))
&& !acls.equals(ZooDefs.Ids.OPEN_ACL_UNSAFE))
- || (!privateWithAuth.equals(acls) &&
!publicWithAuth.equals(acls))) {
- log.error("ZNode at {} has unexpected ACL: {}", path, acls);
+ || (!acls.containsAll(privateWithAuth) &&
!acls.containsAll(publicWithAuth))) {
Review Comment:
Upon second thought, I think it's probably not a good idea to check set
equality, as I said earlier. Users may have customized their ACLs after
installation, and that should be allowed. We only need to check that the
minimum permissions we need, that the Accumulo system user has full permissions
on the nodes for this instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
