ctubbsii commented on code in PR #3124:
URL: https://github.com/apache/accumulo/pull/3124#discussion_r1102930306
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ActiveScanImpl.java:
##########
@@ -55,6 +55,7 @@ public class ActiveScanImpl extends ActiveScan {
private Map<String,Map<String,String>> ssio;
private String user;
private Authorizations authorizations;
+ private String correlationId;
Review Comment:
The problem with correlationId, is that it doesn't clue you in to the
context of what it is correlating. I can imagine half a dozen different
correlationIds in Accumulo... for scans, compactions, RPC requests in general,
writes, bulk ingest, etc. They can't all be called correlationId internally.
They need to be scoped somehow to the context that says more about *what* they
are correlating. That context can be given by the interface the method is
attached to, the class the field is in, or additional information in the log
message, or some other way. But I think it's important to think about and
provide that context somehow, if it isn't present, because "correlationId" by
itself is just too generic of a concept that applies to too many contexts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
