EdColeman commented on code in PR #3124:
URL: https://github.com/apache/accumulo/pull/3124#discussion_r1102963676


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ActiveScanImpl.java:
##########
@@ -55,6 +55,7 @@ public class ActiveScanImpl extends ActiveScan {
   private Map<String,Map<String,String>> ssio;
   private String user;
   private Authorizations authorizations;
+  private String correlationId;

Review Comment:
   If we migrate to using a specific logger like suggested, then the name of 
the logger could signal the context.
   
   In a general sense, the correlationId as a general concept looks to want to 
apply to a more general usage than just a scan. Say that a client reads, 
possibly updates and then writes the modified or new data within the scope of 
one unit of work for the client.  When logged consistently, the correlationId 
could be used to tie all of the log statements for that client operation, scan 
writes,... across servers and processes.
   
   correlationId seems  synonymous with transactionId in this context, without 
the implied atomic and rollback properties that are normally associated with 
transactions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to