cshannon commented on code in PR #17: URL: https://github.com/apache/accumulo-classloaders/pull/17#discussion_r1113189997
########## modules/vfs-class-loader/TESTING.md: ########## @@ -46,12 +46,17 @@ cp ./modules/vfs-class-loader/target/vfs-reloading-classloader-1.0.0-SNAPSHOT.ja Stop Accumulo if it's running and add the following to the accumulo-env.sh: +**Note:** Make sure the commons-vfs2 jar is also on the classpath as well. This dependency was removed in Accumulo 3.0.0 +so if using that version or newer you will need to add it. Also, if you are testing using Uno, do not turn on debug logging +as this will cause errors on start up as the logging to standard out interferes with the configuration parsing. + Review Comment: I think we may need to add an option to change where the logging happens to a file instead of Standard out. Maybe we can provide system args to configure an output logging file that we redirect to. Currently debug logging in the VFS classloader dumps everything into System.out because it can't use log4j as it's not available for the system classloader. So when the [ClusterConfigParser](https://github.com/apache/accumulo/blob/main/core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java) is used by the accumulo command to [parse](https://github.com/apache/accumulo/blob/main/assemble/bin/accumulo-cluster#L69) the yaml it breaks as extra debug statements make it into the config file that the scripts are not expecting later. So to fix this you would need to either configure the VFS classloader logging to log somewhere else as I mentioned or update the ClusterConfigParser in Accumulo to somehow ignore or skip those debug lines when looking for the services. Seems like the logging should just be redirected, I don't think we want to mess with the parser. Looking at it again, it may not just be Uno but all installs that are affected. I don't have anything else but Uno installed to test against but the ClusterConfigParser and accumulo-cluster files are actually both just part of accumulo itself. @dlmarion - do you have something set up to test if starting a cluster breaks if using VFS as a system loader and debug enabled real quick? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
