cshannon commented on code in PR #17:
URL: 
https://github.com/apache/accumulo-classloaders/pull/17#discussion_r1113229619


##########
modules/vfs-class-loader/TESTING.md:
##########
@@ -46,12 +46,17 @@ cp 
./modules/vfs-class-loader/target/vfs-reloading-classloader-1.0.0-SNAPSHOT.ja
 
 Stop Accumulo if it's running and add the following to the accumulo-env.sh:
 
+**Note:** Make sure the commons-vfs2 jar is also on the classpath as well. 
This dependency was removed in Accumulo 3.0.0 
+so if using that version or newer you will need to add it. Also, if you are 
testing using Uno, do not turn on debug logging 
+as this will cause errors on start up as the logging to standard out 
interferes with the configuration parsing.
+

Review Comment:
   Actually I think the cluster parser might be ok, I think that was another 
error I had. I was testing it all day and doing different things so hard to 
keep it stragiht.
   
   I believe it might just be the bash script giving errors. It sources the 
config file after the parser writes to it, which now has a ton of debug 
logging, so that fails. Then when it tries to read the different HOSTS it fails 
because it can't find them. If you want to look into it more and get details 
you will likely have to set up a test yourself with the classloader and see 
what it doesn't as I don't recall exactly the specifics.
   
   Either way, I'm going to create an issue and fix it on Friday so you don't 
need to worry about it. I'm going to update the classloader to take a debug 
config file and we can just create a PrintWriter and write to that file the 
logging statements (debug, info, etc) and don't use System.out at all so we 
don't interfere.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to