EdColeman commented on code in PR #17:
URL: 
https://github.com/apache/accumulo-classloaders/pull/17#discussion_r1113209262


##########
modules/vfs-class-loader/TESTING.md:
##########
@@ -46,12 +46,17 @@ cp 
./modules/vfs-class-loader/target/vfs-reloading-classloader-1.0.0-SNAPSHOT.ja
 
 Stop Accumulo if it's running and add the following to the accumulo-env.sh:
 
+**Note:** Make sure the commons-vfs2 jar is also on the classpath as well. 
This dependency was removed in Accumulo 3.0.0 
+so if using that version or newer you will need to add it. Also, if you are 
testing using Uno, do not turn on debug logging 
+as this will cause errors on start up as the logging to standard out 
interferes with the configuration parsing.
+

Review Comment:
   Where does it fail?  Looking at ClusterConfigParserTest it looks like the 
parser it is reading from file(s) so logging and stdout should not apply? Is it 
this 
[outputShellVariables](https://github.com/apache/accumulo/blob/6d5e5933734f74bb4a3c607a34df32fd93cb8916/core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java#L143)
 that then gets parsed in testing?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to