EdColeman opened a new pull request, #3297:
URL: https://github.com/apache/accumulo/pull/3297
- Fixes tserver initialization so host name and port are reported in metrics
- remove extra tags from thrift metrics
- Update opentelemetry and micrometer versions
- update test to check tag length is sane.
- Includes fix for tag length submitted as PR #3296
Currently, tserver metrics tags do not include the host and there are extra
tags on the thrift metrics. Currently the tags are reported as:
```
METRICS, name: 'accumulo.thrift.idle' num tags: 4, tags:
{process.name=tserver, server=TabletServer, Address=0.0.0.0, thread=Thrift
Client Server}
METRICS, name: 'accumulo.thrift.idle' num tags: 4, tags:
{process.name=tserver, server=TabletServer, Address=0.0.0.0, thread=Thrift
Client Server}
METRICS, name: 'accumulo.thrift.idle' num tags: 4, tags:
{process.name=manager, server=Manager, Address=server1 thread=Manager Client
Service Handler}
METRICS, name: 'accumulo.tserver.scans.files.open' num tags: 3, tags:
{process.name=tserver, statistic=value, Address=0.0.0.0}
METRICS, name: 'accumulo.tserver.compactions.majc.queued' num tags: 4, tags:
{process.name=tserver, statistic=value, Address=0.0.0.0, id=i.meta.huge}
```
This update changes the global tags to always include the host and the port
number:
```
METRICS, name: 'accumulo.thrift.idle' num tags: 3, tags:
{process.name=tserver, port=32779, host=server1}
METRICS, name: 'accumulo.thrift.idle' num tags: 3, tags:
{process.name=tserver, port=39729, host=server1}
METRICS, name: 'accumulo.thrift.idle' num tags: 3, tags:
{process.name=manager, port=43165, host=server1}
METRICS, name: 'accumulo.tserver.scans.files.open' num tags: 4, tags:
{process.name=tserver, statistic=value, port=32779, host=server1}
METRICS, name: 'accumulo.tserver.compactions.majc.running' num tags: 5,
tags: {process.name=tserver, statistic=value, port=32779, host=server1,
id=i.root.huge}
```
Co-authored-by: NAME @ddanielr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
