EdColeman commented on code in PR #3297:
URL: https://github.com/apache/accumulo/pull/3297#discussion_r1168769673
##########
core/src/main/java/org/apache/accumulo/core/metrics/MetricsUtil.java:
##########
@@ -79,9 +79,14 @@ private static void initializeMetrics(boolean enabled,
boolean jvmMetricsEnabled
List<Tag> tags = new ArrayList<>();
tags.add(Tag.of("process.name", processName));
- if (address != null) {
- tags.add(Tag.of("Address", address.toString()));
+ if (address != null && !address.getHost().isEmpty()) {
+ tags.add(Tag.of("host", address.getHost()));
}
+
+ if (address != null && address.getPort() > 0) {
+ tags.add(Tag.of("port", Integer.toString(address.getPort())));
+ }
+
Review Comment:
addressed in aed77f8e67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
