ddanielr commented on PR #384:
URL: https://github.com/apache/accumulo-website/pull/384#issuecomment-1515701644

   # Container use
   
   I wouldn't discount the use of a containerized environment for doing website 
changes as I've had conversations with at least two accumulo devs who plan on 
using it besides myself.
   
   Overall I've found that build environments that can be quickly rebuilt and 
shared helps reduce "works on my machine" issues and update rot.  
   
   # Local Dev issues 
   I chose a source container that matches the current ruby version with the 
hope that there were minimal changes between the containerized environment and 
any bare metal development environments.
   
   The gem lock updates were mostly generated from the containerized version, 
however I'm happy to spend more time seeing if I can eliminate those 
differences. 
   
   # html validation
   
   I explicitly did not add the htmlproofer to the GitHub build step as it 
currently finds thousands of html linking errors in the current site. 
   
   A large majority of these findings are valid
   and I did not want to add a failing build step that would block other 
documentation work. 
   
   Instead, adding it as a manual run option to allow for partial fixes seemed 
the best approach.
   
   However, I can split the validate work into a secondary container that uses 
a separate gem file and should reduce the possibility of conflicts with a local 
dev environment. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to